Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop passing experiment flags to parser for features that have shipped. #1256

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Stop passing experiment flags to parser for features that have shipped. #1256

merged 4 commits into from
Sep 1, 2023

Conversation

munificent
Copy link
Member

Fix #1245.

cc @scheglov

@munificent munificent requested a review from jakemac53 August 28, 2023 23:56
jakemac53
jakemac53 approved these changes Aug 29, 2023
View reviewed changes
lib/src/dart_formatter.dart Outdated Show resolved Hide resolved
jakemac53
jakemac53 reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@jakemac53 jakemac53 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need an API for actually enabling experiments?

@munificent
Copy link
Member Author

munificent commented Sep 1, 2023 •
edited
Loading

I think we also need an API for actually enabling experiments?

Good point! Done. PTAL!

munificent and others added 2 commits September 1, 2023 09:18
@munificent munificent merged commit 711d4fd into main Sep 1, 2023
7 checks passed
@munificent munificent deleted the remove-experiment-flags branch September 1, 2023 17:34
@parlough parlough mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current experiment logic prevents us from being able to expire or remove experiment flags sanely
2 participants
@munificent @jakemac53